[🔥AUDIT🔥] Align variable names in SR strings for interactive graph #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremywiebe
commented
Jan 21, 2025
| @@ -535,8 +535,8 @@ export const strings = { | |||
| "The endpoint is at %(point1X)s comma %(point1Y)s and the ray goes through point %(point2X)s comma %(point2Y)s.", | |||
| srRayGrabHandle: | |||
| "Ray with endpoint %(point1X)s comma %(point1Y)s going through point %(point2X)s comma %(point2Y)s.", | |||
| srRayEndpoint: "Endpoint at %(point1X)s comma %(point1Y)s.", | |||
There was a problem hiding this comment.
These use x and y in the PerseusStrings type and must match.
…active graph type
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (ecc544b) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2131If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2131 |
|
Size Change: -6 B (0%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
jeremywiebe
commented
Jan 21, 2025
There was a problem hiding this comment.
Landing this audit... 🙉🙈
@nishasy please give this a double-check when you have time.
Merged
jeremywiebe
pushed a commit
that referenced
this pull request
Jan 21, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@51.0.1 ### Patch Changes - [#2131](#2131) [`cb15921b8`](cb15921) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix localized string templates for two the ray interactive graph type ## @khanacademy/perseus-editor@17.3.2 ### Patch Changes - Updated dependencies \[[`cb15921b8`](cb15921)]: - @khanacademy/perseus@51.0.1 Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ⏭️ Publish npm snapshot, ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x) Pull Request URL: #2132
nishasy
reviewed
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our localization infrastructure requires that the names of the placeholders in the
stringsvariable (the object with the English strings) matches the variable names in the same-named string generator function that appears in thePerseusStringstype.This PR fixes two new strings so that their placeholder variable names match:
srRayEndpointandsrRayTerminalPoint.Issue: "none"
Test plan:
Do another release and integrate it again and rerun the localization script.