Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Align variable names in SR strings for interactive graph #2131

Merged
merged 2 commits into from
Jan 21, 2025
Merged

[🔥AUDIT🔥] Align variable names in SR strings for interactive graph #2131

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc05d7e
Align variable names in SR strings for interactive graph
jeremywiebe Jan 21, 2025
ecc544b
docs(changeset): Fix localized string templates for two the ray inter…
jeremywiebe Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/perseus/src/strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ export const strings = {
"The endpoint is at %(point1X)s comma %(point1Y)s and the ray goes through point %(point2X)s comma %(point2Y)s.",
srRayGrabHandle:
"Ray with endpoint %(point1X)s comma %(point1Y)s going through point %(point2X)s comma %(point2Y)s.",
srRayEndpoint: "Endpoint at %(point1X)s comma %(point1Y)s.",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These use x and y in the PerseusStrings type and must match.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Sorry about that!

srRayTerminalPoint: "Through point at %(point2X)s comma %(point2Y)s.",
srRayEndpoint: "Endpoint at %(x)s comma %(y)s.",
srRayTerminalPoint: "Through point at %(x)s comma %(y)s.",
// The above strings are used for interactive graph SR descriptions.
} satisfies {
[key in keyof PerseusStrings]:
Expand Down
Loading