Skip to content

Commit

Permalink
[🔥AUDIT🔥] Align variable names in SR strings for interactive graph (#…
Browse files Browse the repository at this point in the history
…2131)

🖍 _This is an audit!_ 🖍

## Summary:

Our localization infrastructure requires that the names of the placeholders in the `strings` variable (the object with the English strings) matches the variable names in the same-named string generator function that appears in the `PerseusStrings` type.

This PR fixes two new strings so that their placeholder variable names match: `srRayEndpoint` and `srRayTerminalPoint`.

Issue: "none"

## Test plan:

Do another release and integrate it again and rerun the localization script.

Author: jeremywiebe

Auditors: jeremywiebe, #perseus, nishasy

Required Reviewers:

Approved By:

Checks: ✅ Check for .changeset entries for all changed files (ubuntu-latest, 20.x), ✅ Publish npm snapshot (ubuntu-latest, 20.x), ✅ Lint, Typecheck, Format, and Test (ubuntu-latest, 20.x), ✅ Cypress (ubuntu-latest, 20.x), ✅ Check builds for changes in size (ubuntu-latest, 20.x), ✅ Publish Storybook to Chromatic (ubuntu-latest, 20.x)

Pull Request URL: #2131
  • Loading branch information
jeremywiebe authored Jan 21, 2025
1 parent 4a9810e commit cb15921
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/friendly-tables-confess.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/perseus": patch
---

Fix localized string templates for two the ray interactive graph type
4 changes: 2 additions & 2 deletions packages/perseus/src/strings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,8 @@ export const strings = {
"The endpoint is at %(point1X)s comma %(point1Y)s and the ray goes through point %(point2X)s comma %(point2Y)s.",
srRayGrabHandle:
"Ray with endpoint %(point1X)s comma %(point1Y)s going through point %(point2X)s comma %(point2Y)s.",
srRayEndpoint: "Endpoint at %(point1X)s comma %(point1Y)s.",
srRayTerminalPoint: "Through point at %(point2X)s comma %(point2Y)s.",
srRayEndpoint: "Endpoint at %(x)s comma %(y)s.",
srRayTerminalPoint: "Through point at %(x)s comma %(y)s.",
// The above strings are used for interactive graph SR descriptions.
} satisfies {
[key in keyof PerseusStrings]:
Expand Down

0 comments on commit cb15921

Please sign in to comment.