Our relationship resolver no longer tries to install conflicting mods. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works when I try to install modules. Hooray!
Nothing uses this any more, and so it can be safely removed. Hooray!
Includes explicit tests for KSP-CKAN#208.
Also, these log messages must rock if people don't know our exceptions are called krakens.
This is such a relief to me.
We also do consistency checks on install and un-install, and the registry will auto-upgrade older vesions with this information, because it's a badass. :)
Plus, our code will remove the directory when the lost mod using it is removed. Pretty cool, eh?
If the user asked for conflicting mods, an InconsistentKraken is thrown.
If mods we're installing or depend upon conflict with recommended or
suggested mods, then the lesser mods are removed from consideration.
I'm a terrible person for not having huge numbers of test cases here,
but I've been tested on huge amounts of CKAN metadata and discovering
*all* my inconsistencies, so I'm pretty sure this works better than
before. :)
Example test:
./ckan.exe install CustomBiomes-Data-RSS CustomBiomes-Data-Stock
|
This PR is really just pjf@e6f9e0c , everything else has already been merged. |
|
Does what it says on the tin :-) |
techman83
added a commit
that referenced
this pull request
Nov 5, 2014
Our relationship resolver no longer tries to install conflicting mods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user asked for conflicting mods, an
InconsistentKrakenis thrown.If mods we're installing or depend upon conflict with recommended or suggested mods, then the lesser mods are removed from consideration.
I'm a terrible person for not having huge numbers of test cases here, but I've been tested on huge amounts of CKAN metadata and discovering all my inconsistencies, so I'm pretty sure this works better than before. :)
Example test:
Includes #263, but happy to re-base if that gets merged and we want an easier to read PR.