Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and prevent file overwrites #208

Closed
pjf opened this issue Oct 31, 2014 · 2 comments
Closed

Detect and prevent file overwrites #208

pjf opened this issue Oct 31, 2014 · 2 comments
Assignees
@pjf
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN
Milestone
v1.0.0 - Galaxy Rise

Comments

@pjf
Copy link
Member

pjf commented Oct 31, 2014

At the moment a mod is able to overwrite the contents of another mod, and we let that happen without saying anything. This is terrible.

We should detect and abort any operation where we see a mod trying to write to an already installed file.
@pjf pjf added Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN labels Oct 31, 2014
@pjf pjf added this to the v1.00 - Usable Release milestone Oct 31, 2014
@pjf pjf added ★★☆ In progress We're still working on this and removed ★★☆ labels Oct 31, 2014
@pjf pjf self-assigned this Nov 5, 2014
pjf added a commit to pjf/CKAN that referenced this issue Nov 5, 2014
@pjf
Updated tests for CopyZipEntry.
383e047 
Includes explicit tests for KSP-CKAN#208.
@pjf
Copy link
Member Author

pjf commented Nov 5, 2014

I have this working, but I'm going to extend my scope a little to see if I can get the registry to have a central record of files and which mod owns which.

We already do this on a per-mod basis, but having a central list opens the door for supporting file replacement (which is a horrible thing), and reporting which mod we're conflicting with (which is a wonderful thing).

@pjf pjf added pull request and removed In progress We're still working on this labels Nov 5, 2014
@pjf
Copy link
Member Author

pjf commented Nov 5, 2014

Closed by #263. :)

@pjf pjf closed this as completed Nov 5, 2014
@pjf pjf removed the pull request label Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjf pjf

Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN
Projects
None yet
Milestone
v1.0.0 - Galaxy Rise
Development

No branches or pull requests
1 participant
@pjf