-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistency checks and file overwrite prevention. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works when I try to install modules. Hooray!
Nothing uses this any more, and so it can be safely removed. Hooray!
Includes explicit tests for KSP-CKAN#208.
Also, these log messages must rock if people don't know our exceptions are called krakens.
This is such a relief to me.
We also do consistency checks on install and un-install, and the registry will auto-upgrade older vesions with this information, because it's a badass. :)
Hold a little on this; while it's okay to be merged, it's fairly common for multiple mods to try and register the same directory, and we should probably be cool with that. |
Plus, our code will remove the directory when the lost mod using it is removed. Pretty cool, eh?
Okay, much happier now! Happy for these to be merged. :) |
techman83
added a commit
that referenced
this pull request
Nov 5, 2014
Consistency checks and file overwrite prevention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is all about making sure we catch ourselves doing silly things. It includes: