Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency checks and file overwrite prevention. #263

Merged
merged 9 commits into from
Nov 5, 2014

Conversation

pjf
Copy link
Member

@pjf pjf commented Nov 5, 2014

This PR is all about making sure we catch ourselves doing silly things. It includes:

  • Improved privacy on fields in the registry class.
  • Files cannot be overwriitten on install
  • We keep a registry of which files are owned by which module (and check it for consistency)
  • Reomoval of deprecated InstallComponent

pjf added 7 commits November 5, 2014 13:07
Works when I try to install modules. Hooray!
Nothing uses this any more, and so it can be safely removed. Hooray!
Includes explicit tests for KSP-CKAN#208.
Also, these log messages must rock if people don't know our exceptions
are called krakens.
This is such a relief to me.
We also do consistency checks on install and un-install, and the
registry will auto-upgrade older vesions with this information, because
it's a badass. :)
@pjf
Copy link
Member Author

pjf commented Nov 5, 2014

Hold a little on this; while it's okay to be merged, it's fairly common for multiple mods to try and register the same directory, and we should probably be cool with that.

pjf added 2 commits November 5, 2014 22:35
Plus, our code will remove the directory when the lost mod using it is
removed. Pretty cool, eh?
@pjf
Copy link
Member Author

pjf commented Nov 5, 2014

Okay, much happier now! Happy for these to be merged. :)

techman83 added a commit that referenced this pull request Nov 5, 2014
Consistency checks and file overwrite prevention.
@techman83 techman83 merged commit 1cdccf7 into KSP-CKAN:master Nov 5, 2014
@pjf pjf deleted the 208_file_overwrites branch November 8, 2014 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants