Allow uninstallation of mods while Incompatible filter is selected #2242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
politas
added a commit
that referenced
this pull request
Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Note that this is not an architectural limitation of Core; if you use the All filter instead, you can uninstall incompatible mods.
Changes
There was an explicit check for the Incompatible filter in
ModList_CellValueChanged, presumably to prevent the user from installing incompatible mods. However, such mods won't have checkboxes anyway. This check is removed.Also added a few null checks to the function to be on the safe side.
Fixes #1842.
Replaces #1929, which was reverted in #2150 due to issues like #2148.
Re-tested #2148 with this change applied, and it worked for me. See my comment on that issue for my ideas about what caused it.