Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall mod is impossible when incompatible filter is selected. #1842

Closed
rem02 opened this issue Jul 27, 2016 · 4 comments
Closed

uninstall mod is impossible when incompatible filter is selected. #1842

rem02 opened this issue Jul 27, 2016 · 4 comments
Assignees
Labels
GUI Issues affecting the interactive GUI

Comments

@rem02
Copy link

rem02 commented Jul 27, 2016

CKAN Version:
v1.18.1-0-g0d2c4f0

Operating System:
Windows 10

How to recreate this issue:
When I filter the list of mods with the incompatible option, I uncheck a mod for the uninstall but the button "Apply Changes" is not activated.

@ayan4m1 ayan4m1 added Bug Something is not working as intended Support Issues that are support requests and removed Bug Something is not working as intended labels Aug 3, 2016
@DianaNites
Copy link

DianaNites commented Oct 24, 2016

I've had this _bug_ too.

It makes it a huge pain when KSP updates and i cant remove mods that havent updated yet.

It's possible that the bug only presents itself when mods that need updates are available, but i wasent able to test because ckan stopped recognize half the files in existing mods, so wouldent update them, so i just deleted the entire GameData folder.

@politas politas added Bug Something is not working as intended GUI Issues affecting the interactive GUI and removed Support Issues that are support requests labels Oct 25, 2016
@politas
Copy link
Member

politas commented Oct 25, 2016

Agreed, it's a bug. Should be able to uninstall mods from the "Installed" or "All" filters, though.

@ayan4m1
Copy link
Contributor

ayan4m1 commented Oct 26, 2016

Sorry, right I misunderstood what was being described. The offending code is

CKAN/GUI/Main.cs

Lines 706 to 709 in fd270eb

if (mainModList.ModFilter == GUIModFilter.Incompatible)
{
return;
}

@HebaruSan
Copy link
Member

The fixing PR was reverted in #2150; re-opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI
Projects
None yet
Development

No branches or pull requests

6 participants