Allow uninstall of incompatible mods in GUI #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you still working on this? Currently, it's not letting me select any mods to install. Actually, I may be a commit behind. Nope, definitely this set of commits. |
|
Need to try and reproduce the issues you're having next time I can (next day or so) |
|
I suspect the problem may be in this bit? https://github.com/ayan4m1/CKAN/blob/fix/apply-changes/GUI/GUIMod.cs#L215-L228 |
|
I can reproduce the issue, working on a fix. |
…the mod list being checkboxes
0b40aed to
318eedb
Compare
|
This should be ready to go now, I found and fixed the issue you were experiencing. |
|
Ooh, sorry, I didn't notice this was ready. I'll have a look tomorrow night. |
|
Ok, that looks really good, now. Excellent work, ayan4m1! |
politas
added a commit
that referenced
this pull request
Oct 13, 2017
This was referenced Oct 17, 2017
politas
added a commit
that referenced
this pull request
Oct 17, 2017
This was referenced Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1842, needs tests but I still can't find a viable way of testing the Main class which is where the ApplyToolButton is declared as a private member.