-
Notifications
You must be signed in to change notification settings - Fork 47
HTTP/2 Support #133
base: master
Are you sure you want to change the base?
HTTP/2 Support #133
Conversation
Updated MbedTLS and HTTP2's version and tests should pass now. |
Base64 encode changed
HTTP Basic Auth fixed
Hey @sorpaas, hoping to merge this soon. I tried rerunning the Travis tests and there seems to be a sporadic failure. Any idea what's going on? |
I still cannot reproduce that locally even now I got a MacBook. On Travis it is still a segmentation fault only on nightly:
Also, any ways to run the Travis build locally on OS X? I thought of Docker but it uses a VM so it's still Linux. |
Also, the line 189 (where it fails) actually doesn't relate to HTTP2:
|
@malmaud Tests now passed on nightly! :) It turns out to be a problem with MbedTLS. Failing back to version 0.2.1 now works. |
It fails again.... :( I guess the segmentation fault is somehow related to MbedTLS. |
- `gzip_data`: Zips provided data and adds "Content-Encoding: gzip" header - `compressed`: Adds "Accept-Encoding: gzip, deflate" header to request
Additional support for GZipped data
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 68.68% 70.92% +2.23%
==========================================
Files 4 4
Lines 511 626 +115
==========================================
+ Hits 351 444 +93
- Misses 160 182 +22
Continue to review full report at Codecov.
|
include Julia 0.5 in tests, remove depwarns
add missing macro-hygiene `esc` to `check_body` macro
Fix Requests on 0.6
try again ci? |
Ah, I'm really sorry that I haven't got this merged. I'll try to re-base the code and do code improvements. (Might take a few days due to my workload recently ...) |
I think HTTP.jl is probably the future of the Julia we stack. Would be
awesome to get it merged there.
…On Mon, Mar 20, 2017 at 2:14 PM Wei Tang ***@***.***> wrote:
Ah, I'm really sorry that I haven't got this merged. I'll try to re-base
the code and do code improvements. (Might take a few days due to my
workload <https://that.world/%7Ewei/busy/> recently ...)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA8SvQ-wTLC-bPAQX6NeYo-xt1gmIlPFks5rnsHogaJpZM4Jc8qw>
.
|
Note I am having the same failure on the http post test at #151 |
This pull request adds HTTP/2 support for Requests.jl. Help on testing and code review are highly appreciated!
To use it, you need to checkout
master
of HPack.jl (header compression implementation), HTTP2.jl (HTTP/2 protocol implementation) and MbedTLS.jl.For a simple test, install nghttp. Run in shell
nghttpd --verbose --no-tls --hexdump 9000
to start a server and then in Julia:To test HTTPS, create a test certificate and key. Start the server by
nghttpd --verbose --hexdump 9000 test.key test.crt
and then in Julia:You can also test it against a server in the real world. Usually, wild HTTP/2 servers require HTTPS support.