This repository has been archived by the owner on May 17, 2019. It is now read-only.
Update dep inner constructor for 0.6 and drop julia 0.4 support #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
strange not sure exactly why this is failing for 0.4 |
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 70.74% 70.36% -0.39%
==========================================
Files 4 4
Lines 523 523
==========================================
- Hits 370 368 -2
- Misses 153 155 +2
Continue to review full report at Codecov.
|
|
fails has started failing independent of this PR, anyone know what is going on there? |
Open
|
these test failures are mysterious cc @tkelman is this ok? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not pretty but it is what it is