Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

HTTP Basic Auth fixed #134

Merged
merged 1 commit into from
Aug 16, 2016
Merged

HTTP Basic Auth fixed #134

merged 1 commit into from
Aug 16, 2016

Conversation

slowbrain
Copy link
Contributor

Base64 encode changed

Base64 encode changed
@malmaud
Copy link
Contributor

malmaud commented Aug 16, 2016

Thanks! Do we have a test for basic auth?

@codecov-io
Copy link

codecov-io commented Aug 16, 2016

Current coverage is 68.62% (diff: 0.00%)

Merging #134 into master will decrease coverage by 0.12%

@@             master       #134   diff @@
==========================================
  Files             4          4          
  Lines           512        510     -2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            352        350     -2   
  Misses          160        160          
  Partials          0          0          

Powered by Codecov. Last update 9eb22b4...77e48bd

@slowbrain
Copy link
Contributor Author

I wish I know how to write a test...
tested it on following:

julia> get("https://user:passwd@httpbin.org/hidden-basic-auth/user/passwd")
Response(200 OK, 11 headers, 47 bytes in body)

@malmaud
Copy link
Contributor

malmaud commented Aug 16, 2016

NP, I'll write the test.

@malmaud malmaud merged commit 24ae937 into JuliaWeb:master Aug 16, 2016
@slowbrain slowbrain deleted the patch-1 branch August 16, 2016 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants