-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assertions in constructor #80
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkamins
changed the title
Remove assertions in constructor
Fix assertions in constructor
Mar 22, 2022
bkamins
commented
Mar 22, 2022
OK - I see you wanted the constructor to be type stable |
bkamins
commented
Mar 22, 2022
bkamins
commented
Mar 22, 2022
bkamins
commented
Mar 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #80 +/- ##
==========================================
+ Coverage 87.00% 88.51% +1.51%
==========================================
Files 1 1
Lines 331 331
==========================================
+ Hits 288 293 +5
+ Misses 43 38 -5
Continue to review full report at Codecov.
|
nalimilan
reviewed
Mar 22, 2022
nalimilan
approved these changes
Mar 23, 2022
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nalimilan I propose to revert b3036f8 you have made. I do not understand why it is needed and currently it leads to an incorrect result: