Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assertions in constructor #80

Merged
merged 7 commits into from
Mar 23, 2022
Merged

Fix assertions in constructor #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6019d8e
Remove assertions in constructor
bkamins Mar 22, 2022
7591190
Update runtests.jl
bkamins Mar 22, 2022
4fb5b3a
Update src/PooledArrays.jl
bkamins Mar 22, 2022
6342148
Update src/PooledArrays.jl
bkamins Mar 22, 2022
67eaf01
Update test/runtests.jl
bkamins Mar 22, 2022
219c5cb
Update test/runtests.jl
bkamins Mar 22, 2022
5026aef
Update runtests.jl
bkamins Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PooledArrays.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ PooledArray
end

# Assertions are needed since _label is not type stable
return PooledArray(RefArray(refs::Vector{R}), invpool::Dict{T,R}, pool)
return PooledArray(RefArray(refs::Array{R, ndims(d)}), invpool::Dict{T,R}, pool)
end

@inline function PooledArray{T}(d::AbstractArray; signed::Bool=false, compress::Bool=false) where {T}
Expand Down
3 changes: 3 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,10 @@ end

for T in (Int8, Int16, Int32, Int64, UInt8, UInt16, UInt32, UInt64)
@inferred PooledArray([1, 2, 3], T)
@inferred PooledArray([1 2 3], T)
end
@test typeof(PooledArray([1 2; 3 4], Int8)) === PooledMatrix{Int, Int8, Matrix{Int8}}

for signed in (true, false), compress in (true, false)
@test_throws ErrorException @inferred PooledArray([1, 2, 3],
signed=signed,
Expand Down