Fix assertions in constructor (#80)

JuliaData · Mar 23, 2022 · ec427e8 · ec427e8 · iamed2 · Mar 23, 2022
1 parent 53f57d4
commit ec427e8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/PooledArrays.jl b/src/PooledArrays.jl
@@ -180,7 +180,7 @@ PooledArray
     end
 
     # Assertions are needed since _label is not type stable
-    return PooledArray(RefArray(refs::Vector{R}), invpool::Dict{T,R}, pool)
+    return PooledArray(RefArray(refs::Array{R, ndims(d)}), invpool::Dict{T,R}, pool)
 end
 
 @inline function PooledArray{T}(d::AbstractArray; signed::Bool=false, compress::Bool=false) where {T}

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -129,7 +129,10 @@ end
 
     for T in (Int8, Int16, Int32, Int64, UInt8, UInt16, UInt32, UInt64)
         @inferred PooledArray([1, 2, 3], T)
+        @inferred PooledArray([1 2 3], T)
     end
+    @test typeof(PooledArray([1 2; 3 4], Int8)) === PooledMatrix{Int, Int8, Matrix{Int8}}
+
     for signed in (true, false), compress in (true, false)
         @test_throws ErrorException @inferred PooledArray([1, 2, 3],
                                                           signed=signed,