Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sparse" alignment image upscaling? #3

Closed
floe opened this issue Jan 22, 2016 · 3 comments
Closed

"Sparse" alignment image upscaling? #3

floe opened this issue Jan 22, 2016 · 3 comments
Assignees

Comments

@floe
Copy link
Contributor

floe commented Jan 22, 2016

Hi again, I'm sort-of misusing the issue tracker as a forum now, feel free to close if not intended :-)

That being said, I noticed that e.g. when using rs::stream::depth_aligned_to_color at a higher color resolution, you get a "sparse" image. This is, of course, expected as https://github.com/IntelRealSense/librealsense/blob/master/src/image.cpp#L356 only maps one single source pixel to a single target pixel.

In libfreenect2, we had implemented a naive-but-mostly-sufficient nearest-neighbor upscaling procedure for this case so that you can get a dense, color-aligned depth image. Would you be interested in a PR implementing a similar behaviour for librealsense? Then I'll prepare one.

@ddiakopoulos
Copy link
Contributor

Hi Florian, thanks for your pull request! This is indeed functionality that is desirable and fitting for inclusion in librealsense. Give us a couple days to work with our legal team on a CLA agreement for this project.

@floe
Copy link
Contributor Author

floe commented Jan 26, 2016

OK, let me know what you need. Instead of a full-scale CLA, would it be sufficient if I also declare my patch to be under Apache-2.0 license?

@sgorsten
Copy link
Contributor

sgorsten commented Mar 2, 2016

Satisfied by pull request #9, merged to master in commit ed4bc85.

Sorry for the long wait.

@sgorsten sgorsten closed this as completed Mar 2, 2016
This was referenced Nov 16, 2017
dorodnic referenced this issue in dorodnic/librealsense Jul 30, 2018
YoshuaNava pushed a commit to YoshuaNava/librealsense that referenced this issue Dec 10, 2018
…alsense_packages

Renamed realsense packages to avoid name conflicts.
dorodnic pushed a commit that referenced this issue Jan 20, 2020
nhershko added a commit to nhershko/librealsense that referenced this issue Feb 23, 2020
nohayassin referenced this issue in nohayassin/librealsense May 12, 2020
1. Remove conversion to float on get_extrinsics()
ev-mp pushed a commit that referenced this issue Oct 5, 2020
nikostsagk pushed a commit to nikostsagk/librealsense that referenced this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants