Test timestamp domain #10925
Merged
Test timestamp domain #10925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Sep 21, 2022
Nir-Az
requested changes
Sep 21, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Sep 22, 2022
Nir-Az
reviewed
Oct 2, 2022
Nir-Az
reviewed
Oct 2, 2022
Nir-Az
reviewed
Oct 2, 2022
| time.sleep(0.7) | ||
| frame = frame_queue.wait_for_frame() | ||
|
|
||
| if frame_queue is None or frame_queue.size() == 0: |
There was a problem hiding this comment.
"if" statement changed to:
if not frame:There was a problem hiding this comment.
Lets keep it simple, at this point of the code we only care about the frame right?
if not frame:
There was a problem hiding this comment.
wait_for_frame() function has timeout 5 sec. It raise Exception if not received frame?
There was a problem hiding this comment.
Yes, you are correct. so we don't even need if not frame: :)
There was a problem hiding this comment.
If we will must to do one addition commit I will remove if not frame: ...
Nir-Az
reviewed
Oct 2, 2022
Nir-Az
reviewed
Oct 2, 2022
Nir-Az
reviewed
Oct 2, 2022
Nir-Az
reviewed
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by LRS-492