-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luv 1.36.0-0 (new formula) #69321
luv 1.36.0-0 (new formula) #69321
Conversation
desc "Bare libuv bindings for lua" | ||
homepage "https://github.com/luvit/luv" | ||
url "https://github.com/luvit/luv/archive/1.36.0-0.tar.gz" | ||
version "1.36.0-0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking: I wonder if it would be worthwhile to add this version scheme to brew
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there enough formulae that use it to make it worthwhile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~17 formulae have a version string of a similar format: https://sourcegraph.com/search?q=repo:homebrew/homebrew-core+version%5C+%5C%22%5Cd%2B%28%5C.%5Cd%2B%29*-%5Cd%2B%5C%22&patternType=regexp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess it might be worthwhile then!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: should the version string 1.36-2
be (1) older than or (2) equal to 1.36.2-0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. I don't know. luv
seems to never leave it out [1], so it might be moot for this formula. However, it may matter elsewhere. Worse: it might be different for different formulae.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?This formula supports #69036 (see also #69319). It could also potentially replace one of neovim's vendored resources.