Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luvit: build from source + depend on luajit-openresty #69036

Closed
wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

Follow up to #68787.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 15, 2021
@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Jan 15, 2021
@carlocab
Copy link
Member Author

There are three problems with this formula. It:

  1. looks for an ARM version of luvi. This doesn't exist.
  2. downloads un-checksummed (but versioned) files, and pipes at least one of them into sh.
  3. downloads binary executables.

@SMillerDev
Copy link
Member

All three are reasons for immediate disabling iyam.

@carlocab
Copy link
Member Author

carlocab commented Jan 19, 2021

I actually have a fix for all three the latter two problems now. Except that it still won't build on ARM. Working on that right now.

carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jan 19, 2021
As mentioned in Homebrew#69036, the formula install block downloads:
- un-checksummed files and pipes one of them into `sh`; and,
- binary executables that are installed into its prefix.

This commit fixes that by bypassing the download and building them all
from source.
This was referenced Jan 19, 2021
@carlocab carlocab force-pushed the luvit-openresty branch 2 times, most recently from 06dbf7b to fa3d987 Compare January 21, 2021 03:13
@carlocab
Copy link
Member Author

Resource luvi doesn't yet build on ARM. Upstream report: luvit/luvi#243

@carlocab carlocab removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 23, 2021
The formula install block downloads:
- un-checksummed files and pipes one of them into `sh`; and,
- binary executables that are installed into its prefix.

This commit fixes that by bypassing the download and building them all
from source.

Follow up to Homebrew#68787.

One of its resources still does not build for Apple Silicon. Reported
upstream at

    luvit/luvi#243
@carlocab carlocab changed the title luvit: depend on luajit-openresty luvit: build from source + depend on luajit-openresty Jan 23, 2021
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@carlocab carlocab deleted the luvit-openresty branch January 24, 2021 03:16
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 24, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants