-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luvit: build from source + depend on luajit-openresty #69036
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three problems with this formula. It:
|
All three are reasons for immediate disabling iyam. |
I actually have a fix for |
carlocab
added a commit
to carlocab/homebrew-core
that referenced
this pull request
Jan 19, 2021
As mentioned in Homebrew#69036, the formula install block downloads: - un-checksummed files and pipes one of them into `sh`; and, - binary executables that are installed into its prefix. This commit fixes that by bypassing the download and building them all from source.
This was referenced Jan 19, 2021
06dbf7b
to
fa3d987
Compare
Resource |
fa3d987
to
57155fe
Compare
The formula install block downloads: - un-checksummed files and pipes one of them into `sh`; and, - binary executables that are installed into its prefix. This commit fixes that by bypassing the download and building them all from source. Follow up to Homebrew#68787. One of its resources still does not build for Apple Silicon. Reported upstream at luvit/luvi#243
57155fe
to
1857243
Compare
SeekingMeaning
approved these changes
Jan 23, 2021
🤖 A scheduled task has triggered a merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #68787.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?