Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luvit: build from source #69319

Closed
wants to merge 1 commit into from
Closed

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Jan 19, 2021

As mentioned in #69036, the formula install block downloads:

  • un-checksummed files and pipes one of them into sh; and,
  • binary executables that are installed into its prefix.

This commit fixes that by bypassing the download and building them all
from source.


  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

As mentioned in Homebrew#69036, the formula install block downloads:
- un-checksummed files and pipes one of them into `sh`; and,
- binary executables that are installed into its prefix.

This commit fixes that by bypassing the download and building them all
from source.
@BrewTestBot BrewTestBot added the no ARM bottle Formula has no ARM bottle label Jan 19, 2021
@carlocab carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 19, 2021
@carlocab
Copy link
Member Author

The ARM build failure comes from the resource luvi, which has a vendored dependency luv, which fails to build, found here: https://github.com/luvit/luvi/tree/v2.11.0/deps

luv has its vendored dependencies in https://github.com/luvit/luv/tree/02237cdab45f264351d30128e21c14fe5959a2d6/deps. I am fairly certain the build failure comes from either vendored libuv or vendored luajit. In either case, the solution would be to get the build to use Homebrew's versions of both, and that should get this to build on ARM.

@carlocab carlocab removed the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 19, 2021
@carlocab carlocab mentioned this pull request Jan 19, 2021
5 tasks
@carlocab
Copy link
Member Author

Here's a start at the attempt of getting luvit to build on ARM: #69321

@SeekingMeaning
Copy link
Contributor

SeekingMeaning commented Jan 23, 2021

Revision bump? (Not sure myself)

@carlocab
Copy link
Member Author

Not sure... But I guess I don't mind closing this in favour of #69036. I make changes that are worth a revision bump there.

@carlocab carlocab closed this Jan 23, 2021
@carlocab carlocab deleted the luvit-build branch January 23, 2021 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no ARM bottle Formula has no ARM bottle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants