-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
๐ :: Api-v0.0.8 #219
Merged
Merged
๐ :: Api-v0.0.8 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat : ์ฃผ๋ฌธ ์ฒ ํ์ ์ฟ ํฐ ํ๋ณต ๋ก์ง ๊ตฌํ * refactor : ํธ๋ค๋ฌ๋ช ๋ณ๊ฒฝ * feat : ์ฟ ํฐ ํ ์ธ ๊ธ์ก ๊ฒ์ฆ์ ์๋ฌ ๋ฐ์ ๋ก์ง ์ถ๊ฐ * bug : ์ฟ ํฐ ์ฌ์ฉ, ํ๋ณต์ ๋ฝ์ด๋ฆ ํต์ผ * feat : ์ฟ ํฐ ํ๋ณต ๋์์ฑ ์ด์ ๊ฒ์ฆ ์ถ๊ฐ
* test : ์ฃผ๋ฌธ์ทจ์ ์ฒ ํ๊ด๋ จ ํ ์คํ ์ฝ๋ ์ถ๊ฐ * test : ์ฃผ๋ฌธ์ทจ์ ์ฒ ํ์ ํ ์ค ์ทจ์์์ฒญ ํ ์คํ ์ถ๊ฐ * ci : stacktrace ์ถ๊ฐ
* refactor : ํ๋๋ฉ์ธ ์์กด์ฑ 1์ฐจ ์ ๊ฑฐ * style : spotless * refactor : validator ๋ถ๋ฆฌ, ์คํ ์ ๊ฒ * refactor : createOrderResponse mapper ๋ก ๋ณํ * refactor : orderResponse mapper ๊ตฌํ๋ ๋ฐฉ์ ๋ฆฌํฉํ ๋ง * refactor : createIssuedTicket ๋ฆฌํฉํ ๋ง * refactor : issuedTicket ๋ฐํ๋ก์ง ๋ฆฌํฉํ ๋ง * test : test ์ฝ๋ ๋์๊ฐ๊ฒ ์์ * styel : spotless * test : ์ฃผ๋ฌธ ๊ฒ์ฆ ๋๋ฉ์ธ ํ ์คํธ ์ถ๊ฐ * feat : validator ์ด๋ ธํ ์ด์ ์ถ๊ฐ
* feat : ๋ด ์ฟ ํฐ ์กฐํ API ์์ฑ * refactor : RequestParam ์๋ฃํ ๋ณ๊ฒฝ ๋ฐ defaultValue ์ค์ * refactor : ์ ํจ ๊ธฐ๊ฐ ๊ฒ์ฆ ๋ก์ง ๋๋ฉ์ธ ๋ด ํจ์ํ
* feat : ํธ์คํธ ํ๋กํ ๋ฆฌ์คํธ ์๋ต ์ถ๊ฐ * feat : page ์ ์ฉ * fix : ์ด๋ฒคํธ ๋ํ ์ผ lazy ๋ก๋ฉ ๋ฌธ์ ์์ * feat : ํธ์คํธ ์ด๋ฒคํธ ์กฐํ ํ์ด์ง ์ ์ฉ * chore : spotless apply
* refactor : order ์์ฑ๊ด๋ จ ๋ฆฌํฉํ ๋ง * refactor : cart item response ๋ฆฌํฉํฐ๋ง * feat : ์ฅ๋ฐ๊ตฌ๋ ๋ด์ ๋ ๊ฒ์ฆ ๋ฉ์๋ ์ถ๊ฐ * refactor : ์นดํธ ์์ฑ์ ์ ์ ํฉํฐ๋ฆฌ ๋ฉ์๋ ์ฌ์ฉ * refactor : ์ฃผ๋ฌธ ๋ฒํธ ํ์ ์์ * test: ํ ์คํธ ๋์๊ฐ๊ฒ ์์ * test : cartValidator ๊ด๋ จ ํ ์คํธ ์ถ๊ฐ * ci : sonar test coverage ๊ด๋ จ ์ ๋ฐ์ดํธ * style : spotless * test : cartValidator ํ ์คํธ ์ฝ๋ ๋ง์ ์ถ๊ฐ * test : cartLineItem test * test : cart ๋๋ฉ์ธ ํ ์คํธ ์ฝ๋ ์ถ๊ฐ
* refactor(itemOptionGroup) : ํฐ์ผ์ํ ๋ด ์ต์ ๊ทธ๋ฃน ๊ด๋ฆฌ ๋๋ฉ์ธ ๋ฉ์๋ ์์ฑ * refactor(itemOptionGroup) : ์์ฒญDTO ๋ด id๊ฒ์ฆ ์ด๋ ธํ ์ด์ ์ฌ์ฉ * refactor(itemOptionGroup) : ์ต์ ์ ์ฉ ๋ก์ง ๊ตฌ์กฐ ๋ฆฌํํ ๋ง ๋ฐ ๊ฒ์ฆ ์ถ๊ฐ * refactor(itemOptionGroup) : ์๋ฌ์ฝ๋ ์ปจํ๋ฆญํธ ํด๊ฒฐ * refactor(itemOptionGroup) : ๋ถ์ฐ๋ฝ, ๋๋ฉ์ธ ๋ด๋ถ๋ก ๋ฉ์๋ ์ด, ์๋ฌ์ฝ๋ ์์
ImNM
requested review from
sanbonai06,
cofls6581,
gengminy and
kim-wonjin
as code owners
January 29, 2023 11:07
Kudos, SonarCloud Quality Gate passed!ย ย 0 Bugs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๊ฐ์
์์ ์ฌํญ
๋ณ๊ฒฝ๋ก์ง