Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test : 주문 취소 철회 관련 테스트 추가 #202

Merged
merged 4 commits into from
Jan 26, 2023
Merged

test : 주문 취소 철회 관련 테스트 추가 #202

merged 4 commits into from
Jan 26, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 26, 2023

개요

작업사항

  • 버그인줄 알았는데
  • 앞 pr 에서 로직이 변화하면서
  • 자동으로 고쳐졌습니다.
  • 대신 테스트 코드를 추가했습니다

앞에 분들 머지되면 컨플릭트 안나도록
코드올렸습니다..,, 지송 ㅎㅎ

변경로직

  • 내용을 적어주세요.

@ImNM ImNM added For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정 labels Jan 26, 2023
@ImNM ImNM self-assigned this Jan 26, 2023
cofls6581
cofls6581 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

gengminy
gengminy approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 👍

@ImNM
Copy link
Member Author

ImNM commented Jan 26, 2023

https://sonarcloud.statuspage.io

소나 클라우드쪽에서 DNS 문제로 테스트 통과가 안되구있네요
잠시 해결될때까지 기달려야할둣!

@ImNM ImNM merged commit c3649af into dev Jan 26, 2023
@ImNM ImNM deleted the fix/190-withdraw-toss-cancel-check branch January 26, 2023 17:56
@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengminy gengminy gengminy approved these changes

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

@kim-wonjin kim-wonjin Awaiting requested review from kim-wonjin kim-wonjin is a code owner

Assignees

@ImNM ImNM

Labels
For: Utils [이슈 대상] API, 모델, 뷰를 제외한 백엔드 로직 Type: Test Type: Test [이슈 목적] 테스트 코드 추가, 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG] 주문 철회시 선착순 무료 결젠 토스로 취소요청 안보내기
3 participants
@ImNM @cofls6581 @gengminy