Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cart) : 장바구니 도메인 타 도메인 연관관계 제거 #213

Merged
merged 13 commits into from
Jan 28, 2023
Merged

refactor(cart) : 장바구니 도메인 타 도메인 연관관계 제거 #213

merged 13 commits into from
Jan 28, 2023

Conversation

ImNM
Copy link
Member

@ImNM ImNM commented Jan 28, 2023 •
edited
Loading

개요

작업사항

  • 장바구니 도메인에서 타 도메인과의 연관관계를 없앴습니다.
  • cartValidator를 두었습니다.

장바구니에 상품을 담기전

공연이 열려있는지, 아이템 재고는 남아있는지, 옵션에 대한 응답은 잘했는지,
이벤트가 시작하기 전 티켓팅이 가능한 시간인지 등등을 확인합니다.

  • 위검증은 추후 주문 쪽에도 추가할예정입니다.

변경로직

  • 연관관계없애면서 지금 ddl 이 update 라서 아마 장바구니 만들면 안될텐데

  • 장바구니 관련 디비 테이블 날리고 진행해주세요 아직 형상관리가없어서리..

  • 옵션쪽 응답을 예 아니요 로 해놨습니다 피그마 맞춰서 @kim-wonjin

@ImNM ImNM added For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링 labels Jan 28, 2023
@ImNM ImNM self-assigned this Jan 28, 2023
cofls6581
cofls6581 approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@cofls6581 cofls6581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

장바구니 관련 테이블 날려야하는 거 확인! 고생하셨습니다~~

gengminy
gengminy approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@gengminy gengminy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kim-wonjin
kim-wonjin approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@kim-wonjin kim-wonjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오케이 응답 맞춰서 수정하겠숨다🫡

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 222 Code Smells

15.9% 15.9% Coverage
0.0% 0.0% Duplication

@ImNM ImNM merged commit 95f0743 into dev Jan 28, 2023
@ImNM ImNM deleted the refactor/209-cart-ddd branch January 28, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-wonjin kim-wonjin kim-wonjin approved these changes

@gengminy gengminy gengminy approved these changes

@cofls6581 cofls6581 cofls6581 approved these changes

@sanbonai06 sanbonai06 Awaiting requested review from sanbonai06 sanbonai06 is a code owner

Assignees

@ImNM ImNM

Labels
For: API [이슈 대상] 외부 API Type: Refactor [이슈 목적] 프로덕션 코드 리팩토링
Projects
None yet
Milestone
No milestone
4 participants
@ImNM @cofls6581 @gengminy @kim-wonjin