Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always add namespaces in generated manifests regardless of offline=[true|false] #8124

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

aaron-prindle
Copy link
Contributor

@aaron-prindle aaron-prindle commented Nov 20, 2022

fixes #8105

The comment there:

consult with cloud deploy team if namespaces can be set in offline mode
	// in case namespace is set on the skaffold render cli command.

mentioned talking w/ Cloud Deploy team. In a recent discussion w/ the Cloud Deploy team they have stated that the functionality they want here is that namespaces are modified in manifests during skaffold render for both offline=[true|false].

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #8124 (1fe5321) into main (290280e) will decrease coverage by 4.20%.
The diff coverage is 53.26%.

@@            Coverage Diff             @@
##             main    #8124      +/-   ##
==========================================
- Coverage   70.48%   66.28%   -4.21%     
==========================================
  Files         515      599      +84     
  Lines       23150    29347    +6197     
==========================================
+ Hits        16317    19452    +3135     
- Misses       5776     8448    +2672     
- Partials     1057     1447     +390     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/app/exitcode.go 100.00% <ø> (+6.66%) ⬆️
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) ⬇️
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) ⬇️
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) ⬇️
... and 394 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

skaffold render offline=[true|false] behaviour for namespaces is not the same
2 participants