Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skaffold render offline=[true|false] behaviour for namespaces is not the same #8105

Closed
aaron-prindle opened this issue Nov 16, 2022 · 1 comment · Fixed by #8124
Closed
Assignees
Labels
kind/todo implementation task/epic for the skaffold team source/partnerships
Milestone

Comments

@aaron-prindle
Copy link
Contributor

Currently skaffold render offline=[true|false] behaviour for namespaces is not the same. This should be the same (both of them set namespaces) but is not currently and as such can cause error/unneeded confusion for users

Related code comment:

// TODO(tejaldesai) consult with cloud deploy team if namespaces can be set in offline mode
// in case namespace is set on the skaffold render cli command.

@aaron-prindle
Copy link
Contributor Author

Additional context, the Cloud Deploy team specifically requested this as it is necessary functionality for skaffold render to set these namespaces regardless of offline=[true|false] for upcoming features in their roadmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/todo implementation task/epic for the skaffold team source/partnerships
Projects
None yet
1 participant