Skip to content

Commit

Permalink
fix: always add namespaces in generated manifests regardless of offli…
Browse files Browse the repository at this point in the history
…ne=[true|false]
  • Loading branch information
aaron-prindle committed Nov 20, 2022
1 parent 865a51a commit 176ef4f
Showing 1 changed file with 5 additions and 7 deletions.
12 changes: 5 additions & 7 deletions pkg/skaffold/render/renderer/util/util.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,12 @@ func GenerateHydratedManifests(ctx context.Context, out io.Writer, builds []grap
if manifests, err = manifests.SetLabels(labels, manifest.NewResourceSelectorLabels(opts.TransformAllowList, opts.TransformDenylist)); err != nil {
return nil, err
}
// TODO(tejaldesai) consult with cloud deploy team if namespaces can be set in offline mode
// in case namespace is set on the skaffold render cli command.
if !opts.Offline {
if manifests, err = manifests.SetNamespace(ns, rs); err != nil {
return nil, err
}
endTrace()

if manifests, err = manifests.SetNamespace(ns, rs); err != nil {
return nil, err
}
endTrace()

var platforms manifest.PodPlatforms

if opts.EnableGKEARMNodeToleration && isGKECluster(opts.KubeContext) {
Expand Down

0 comments on commit 176ef4f

Please sign in to comment.