Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend dependencies #42

Merged
merged 17 commits into from
Feb 2, 2025

Conversation

kyasbal
Copy link
Member

@kyasbal kyasbal commented Jan 30, 2025

TODOs:

Major notable changes:

  • Angular 17 -> 19
  • Migrate components to standalone as much as possible
  • Get rid of ngx-env

@kyasbal
Copy link
Member Author

kyasbal commented Jan 31, 2025

Now it works with Angular 19. I need to fix tests and reduce non necessary module dependencies.

image

@kyasbal kyasbal force-pushed the update-frontend-dependency branch from f12307f to d856f2f Compare January 31, 2025 13:15
@kyasbal kyasbal marked this pull request as ready for review January 31, 2025 14:11
@kyasbal kyasbal requested a review from renamoo as a code owner January 31, 2025 14:11
Copy link
Collaborator

@renamoo renamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check two points

@kyasbal kyasbal mentioned this pull request Jan 31, 2025
@kyasbal kyasbal requested a review from renamoo January 31, 2025 23:16
Copy link
Collaborator

@renamoo renamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the responses! LGTM

@kyasbal
Copy link
Member Author

kyasbal commented Feb 1, 2025

I'll merge this next week not to break frontend code on the main branch when I can't fix it soon. (I'm on a travel this weekend)

@kyasbal kyasbal merged commit c75a8da into GoogleCloudPlatform:main Feb 2, 2025
6 checks passed
@kyasbal kyasbal deleted the update-frontend-dependency branch February 2, 2025 12:38
@kyasbal kyasbal mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants