Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET /config API #46

Closed
kyasbal opened this issue Jan 31, 2025 · 0 comments · Fixed by #47
Closed

Add GET /config API #46

kyasbal opened this issue Jan 31, 2025 · 0 comments · Fixed by #47

Comments

@kyasbal
Copy link
Member

kyasbal commented Jan 31, 2025

Background

KHI frontend code relied on build time environment variable to change some configurations on frontend. The viewer mode configuration is an example, which can be enabled on backend CLI parameter, but frontend needs to be built with an environment variable.

Related #42

Solution

Add GET /config API to return current configuration needed for the frontend. This API will be called at the beginning of frontend code being loaded.
This API doesn't receive any request parameter, and response is just a map and we may add additional fields on the map later.

@kyasbal kyasbal linked a pull request Feb 2, 2025 that will close this issue
@kyasbal kyasbal mentioned this issue Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant