Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config API #47

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Add config API #47

merged 5 commits into from
Feb 3, 2025

Conversation

kyasbal
Copy link
Member

@kyasbal kyasbal commented Feb 2, 2025 •
edited
Loading

Context: #46

@kyasbal kyasbal linked an issue Feb 2, 2025 that may be closed by this pull request
Add GET /config API #46
Closed
@kyasbal kyasbal marked this pull request as ready for review February 2, 2025 13:52
renamoo
renamoo approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@renamoo renamoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Typescript

RyuSA
RyuSA approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@RyuSA RyuSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM(server side)

jyane
jyane approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@jyane jyane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyasbal kyasbal merged commit bb9dc51 into GoogleCloudPlatform:main Feb 3, 2025
6 checks passed
@kyasbal kyasbal deleted the config-api branch February 3, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyane jyane jyane approved these changes

@RyuSA RyuSA RyuSA approved these changes

@renamoo renamoo renamoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GET /config API
4 participants
@kyasbal @jyane @RyuSA @renamoo