Feature/aoloso/hybrid openmp #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges in GOCART2G
…ption error when using multiple OpenMP threads in GOCART2G
…s of the internal states of gridcomps
…nges to allow gfortran to compile BaseProfiler.F90
…ce condition when using OpenMP
… for the Intel compiler to work correctly when using multiple threads
…Added accessors (set and get) for component level variable use_threads
…e that is already checked in MAPL_GenericWrapper
tclune
reviewed
Sep 6, 2022
tclune
reviewed
Sep 6, 2022
tclune
reviewed
Sep 6, 2022
|
OK - presumably something in this PR triggered this. Presumably it is MaplGrid. Looking... |
|
OK - this is perverse. The "units" argument is not even used by ESMFL, so there is no reason to specify it! In any even the named constant should be moved to ESMFL should be treated as deprecated, but we can't delete it just yet. |
…PL_UnitsRadians in InternalConstants.F90. Did a global search/replace. This avoid the circular dependency build error when ESMF_UnitsRadians is used in MaplGrid.F90
tclune
reviewed
Sep 14, 2022
mathomp4
reviewed
Sep 16, 2022
tclune
reviewed
Sep 22, 2022
…RT non-saved local variables
tclune
previously approved these changes
Sep 23, 2022
|
I tested this (along with #1683) with the GCM and it seems zero-diff and good to go. |
7 tasks
mathomp4
reviewed
Sep 26, 2022
mathomp4
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Several changes to support component level hybrid MPI/OpenMP.
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: