Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ninja build of MAPL #1673

Merged
merged 6 commits into from
Sep 15, 2022
Merged

Add Ninja build of MAPL #1673

merged 6 commits into from
Sep 15, 2022

Conversation

mathomp4
Copy link
Member

@mathomp4 mathomp4 commented Sep 15, 2022 •
edited
Loading

Description

This PR adds a Ninja build of MAPL along with the usual GNU Make.

Related Issue

Motivation and Context

Ninja builds can often help show build errors in better ways, see #1655 (comment)

How Has This Been Tested?

If the CI works, it works!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@mathomp4 mathomp4 added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Sep 15, 2022
@mathomp4 mathomp4 self-assigned this Sep 15, 2022
@mathomp4
Copy link
Member Author

Sigh. I actually have to install Ninja in Docker images

@mathomp4 mathomp4 marked this pull request as ready for review September 15, 2022 19:02
@mathomp4 mathomp4 requested a review from a team as a code owner September 15, 2022 19:02
@mathomp4 mathomp4 merged commit 59663eb into develop Sep 15, 2022
@mathomp4 mathomp4 deleted the feature/mathomp4/add-ninja-build branch September 15, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bena-nasa bena-nasa bena-nasa approved these changes

Assignees

@mathomp4 mathomp4

Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathomp4 @bena-nasa