Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/aoloso/hybrid openmp #1699

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Feature/aoloso/hybrid openmp #1699

merged 4 commits into from
Oct 3, 2022

Conversation

aoloso
Copy link
Contributor

@aoloso aoloso commented Sep 29, 2022 •
edited by mathomp4
Loading

Description

  • Made changes consistent with MAPL for accessor functions to get number of threads and current thread

Related Issue

Motivation and Context

  • To be consistent with naming of MAPL functions used outside of MAPL

How Has This Been Tested?

  • Zero-diff with baseline

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@aoloso aoloso added the 0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) label Sep 29, 2022
@aoloso aoloso requested review from a team as code owners September 29, 2022 21:16
@aoloso aoloso changed the base branch from main to develop September 29, 2022 21:17
@mathomp4
Copy link
Member

@aoloso These changes are above and beyond the first OpenMP PR you made: #1655 ?

@mathomp4 mathomp4 merged commit 25d5d82 into develop Oct 3, 2022
@mathomp4 mathomp4 deleted the feature/aoloso/hybrid-openmp branch October 3, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune approved these changes

Assignees
No one assigned
Labels
0 Diff Trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aoloso @mathomp4 @tclune