Propagates llmclient changes to ldp #226
Merged
+2,255
−911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
reviewed
Jan 29, 2025
7 tasks
jamesbraza
reviewed
Feb 11, 2025
jamesbraza
reviewed
Feb 11, 2025
jamesbraza
reviewed
Feb 12, 2025
jamesbraza
approved these changes
Feb 12, 2025
codeflash-ai bot
added a commit
that referenced
this pull request
Feb 19, 2025
…8% in PR #226 (`update-llmclient`) In this optimized version of the function `prep_tools_for_tokenizer`, I've replaced the loop where the tool information is manually constructed with a list comprehension that calls the hypothetical `model_dump()` method. This assumes that such a method exists and returns the desired dictionary structure, making the code both faster and more concise. This method leverages what seems like an existing serialization method within the `Tool` class's `info` attribute, thereby minimizing manual dictionary creation and potentially optimizing runtime performance through internal optimizations within `model_dump()`.
⚡️ Codeflash found optimizations for this PR📄 33,608% (336.08x) speedup for
|
jamesbraza
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft. A new
fh-llm-clientrelease is still needed.TODO:
llmclientv0.1.0fh-llm-clientdependency inpyproject.toml