Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagates llmclient changes to ldp #226

Merged
merged 32 commits into from
Feb 20, 2025
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
c68a996
Deprecated MultiCompletionLLMModel import in favor of LiteLLMModel
maykcaldas Jan 27, 2025
503572c
Merge branch 'main' into update-llmclient
maykcaldas Jan 27, 2025
e875d0b
Changed nomenclature of LLMModel.model to LLMModel.name
maykcaldas Jan 28, 2025
628d6b2
Updated cassettes
maykcaldas Jan 28, 2025
4d42907
Merge branch 'main' into update-llmclient
maykcaldas Jan 28, 2025
c11b67a
updated uv.lock
maykcaldas Jan 28, 2025
4d47d6f
Added comments to discussion
maykcaldas Jan 29, 2025
85abf88
Removed match from vcr in tests
maykcaldas Jan 29, 2025
59b659d
Reverted some changes fixed on llmclient side
maykcaldas Jan 29, 2025
b5c91f8
Cleaned some solved comments
maykcaldas Jan 29, 2025
52dfd16
Added check if the agent got an answer
maykcaldas Jan 30, 2025
0cef2fa
Merge branch 'main' into update-llmclient
maykcaldas Feb 10, 2025
4662f23
Merge branch 'main' into update-llmclient
maykcaldas Feb 11, 2025
fcb6679
Added changed cassette
maykcaldas Feb 11, 2025
d71febf
Fixed pre-commit
maykcaldas Feb 11, 2025
86b1e9f
Updated test_ops to check if empty tool calls return ToolRequestMessage
maykcaldas Feb 12, 2025
b5ca985
Upgrade uv.lock pre-commit
maykcaldas Feb 12, 2025
ee667e9
Reverted unneeded changes in test_ops
maykcaldas Feb 12, 2025
1c17213
Merge branch 'main' into update-llmclient
maykcaldas Feb 19, 2025
b82bb8d
Updated mailmap
maykcaldas Feb 19, 2025
b0d0b73
updated cassets of failing tests
maykcaldas Feb 19, 2025
1947989
Updated fhaviary version
maykcaldas Feb 19, 2025
38d7871
formatted cassets
maykcaldas Feb 19, 2025
b857991
Added more corrections for fhaviaryv0.18.2 import
maykcaldas Feb 19, 2025
ed8c9f3
Avoided logprobs serialization
maykcaldas Feb 19, 2025
e172614
fix pre-commit
maykcaldas Feb 19, 2025
27cc9ea
Fixed OpResult deserialization by discarding logprob after #197 misse…
jamesbraza Feb 19, 2025
dc4cf41
Merge branch 'fixing-http-agent-lifecycle-test' into update-llmclient
maykcaldas Feb 19, 2025
849ff76
Reverted change that avoided serializing logprobs
maykcaldas Feb 19, 2025
f9ffaee
Merge branch 'main' into update-llmclient
maykcaldas Feb 19, 2025
5572259
Updated cassettes
maykcaldas Feb 20, 2025
e386c07
Bumped llmclient version
maykcaldas Feb 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reverted change that avoided serializing logprobs
maykcaldas committed Feb 19, 2025
commit 849ff76118955b0148583b478971e5fdd7051e27
4 changes: 1 addition & 3 deletions ldp/graph/ops.py
Original file line number Diff line number Diff line change
@@ -61,9 +61,7 @@ def to_dict(self) -> dict[str, Any]:
"op_name": self.op_name,
"op_class_name": self.op_class_name,
"value": value_dump,
# NOTE: logprob is not a OpResult attribute. So this breaks serialization
#
# "logprob": self.logprob,
"logprob": self.logprob,
}

@classmethod