Suppress env frame errors; serialize logprob #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesbraza
approved these changes
Dec 30, 2024
ldp/data_structures.py
Outdated
Comment on lines
126
to
129
| # logprob may have been serialized, but cnanot be passed to | ||
| # OpResult, so remove it here. | ||
| with suppress(KeyError): | ||
| data["action"].pop("logprob") |
There was a problem hiding this comment.
Why can logprob not be passed to OpResult's action?
Also, typo in "cannot"
There was a problem hiding this comment.
logprob is a property that we extract from the OpCtx, not an attribute of the OpResult, so there's no way to set it on OpResult deserialization - the correct thing to do is also hydrate the OpCtx from the backend.
jamesbraza
added a commit
that referenced
this pull request
Feb 19, 2025
jamesbraza
added a commit
that referenced
this pull request
Feb 19, 2025
jamesbraza
added a commit
that referenced
this pull request
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TrajectoryFileCallbackchanges assumed that all envs implementedexport_frame(); this loosens that assumptionOpResults