Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade vscode engine to match types/vscode dep version #32

Closed
wants to merge 1 commit into from

Conversation

JoshuaBatty
Copy link
Member

@JoshuaBatty JoshuaBatty commented Mar 4, 2022

I was getting an error when running npm run install-extension

@types/vscode ^1.64.0 greater than engines.vscode ^1.55.0. Consider upgrade engines.vscode or use an older @types/vscode version

I found the same error reported here

The vscode engine needs to be upgraded to match the types/vscode dep.

@JoshuaBatty JoshuaBatty requested review from adlerjohn and AlicanC March 4, 2022 00:26
@JoshuaBatty JoshuaBatty self-assigned this Mar 4, 2022
@JoshuaBatty
Copy link
Member Author

Just noticed @adlerjohn already upgraded this version in #30 but it's since been reverted... ?

@adlerjohn
Copy link
Contributor

adlerjohn commented Mar 4, 2022

No, it's because #30 was merged into #29, which contains CI to actually catch the error!

@JoshuaBatty
Copy link
Member Author

Closing as @adlerjohn already has this on his radar, should have looked at the other PR's first.

@JoshuaBatty JoshuaBatty closed this Mar 4, 2022
@JoshuaBatty JoshuaBatty deleted the josh/upgrade_vscode_engine branch July 7, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants