-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dry run publish to CI #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump vscode version to 1.64.0 * Install vsce as a dev dependency. * Attempt to fix ci * revert * Install prettier as dev dep * Don't use npx * Don't use action for format check.
adlerjohn
commented
Feb 28, 2022
Comment on lines
+23
to
+27
- name: Dry run publish | ||
uses: HaaLeo/publish-vscode-extension@v1 | ||
with: | ||
pat: "quickbrownfox" | ||
dryRun: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially the only change in this PR, the rest is cosmetic or was merged from #30
adlerjohn
requested review from
AlicanC,
JoshuaBatty,
mitchmindtree and
QuinnLee
February 28, 2022 13:35
JoshuaBatty
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets do it.
sdankel
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add dry run publish to CI * Rename * Refactor workflows. * Remove redundant newlines. * Fix * Fix: add required pat * Should fix ci * Should fix publish * Bump vscode version to 1.64.0 (#30) * Bump vscode version to 1.64.0 * Install vsce as a dev dependency. * Attempt to fix ci * revert * Install prettier as dev dep * Don't use npx * Don't use action for format check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #30