Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry run publish to CI #29

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Add dry run publish to CI #29

merged 9 commits into from
Mar 4, 2022

Conversation

adlerjohn
Copy link
Contributor

@adlerjohn adlerjohn commented Feb 27, 2022

Requires #30

@adlerjohn adlerjohn self-assigned this Feb 27, 2022
* Bump vscode version to 1.64.0

* Install vsce as a dev dependency.

* Attempt to fix ci

* revert

* Install prettier as dev dep

* Don't use npx

* Don't use action for format check.
Comment on lines +23 to +27
- name: Dry run publish
uses: HaaLeo/publish-vscode-extension@v1
with:
pat: "quickbrownfox"
dryRun: true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially the only change in this PR, the rest is cosmetic or was merged from #30

Copy link
Member

@JoshuaBatty JoshuaBatty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, lets do it.

@adlerjohn adlerjohn merged commit 935df37 into master Mar 4, 2022
@adlerjohn adlerjohn deleted the adlerjohn/ci-dry-run branch March 4, 2022 01:00
sdankel pushed a commit that referenced this pull request Apr 17, 2024
* Add dry run publish to CI

* Rename

* Refactor workflows.

* Remove redundant newlines.

* Fix

* Fix: add required pat

* Should fix ci

* Should fix publish

* Bump vscode version to 1.64.0 (#30)

* Bump vscode version to 1.64.0

* Install vsce as a dev dependency.

* Attempt to fix ci

* revert

* Install prettier as dev dep

* Don't use npx

* Don't use action for format check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants