Bump vscode version to 1.64.0 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be reviewed separately before merging into #29 |
adlerjohn
commented
Feb 28, 2022
| uses: creyD/prettier_action@v4.2 | ||
| with: | ||
| prettier_options: --check client/src snippets syntaxes | ||
| - run: npm run format:check |
There was a problem hiding this comment.
Prior to this change, the action would cd into another directory and mess up subsequent steps.
QuinnLee
approved these changes
Feb 28, 2022
adlerjohn
added a commit
that referenced
this pull request
Mar 4, 2022
* Add dry run publish to CI * Rename * Refactor workflows. * Remove redundant newlines. * Fix * Fix: add required pat * Should fix ci * Should fix publish * Bump vscode version to 1.64.0 (#30) * Bump vscode version to 1.64.0 * Install vsce as a dev dependency. * Attempt to fix ci * revert * Install prettier as dev dep * Don't use npx * Don't use action for format check.
sdankel
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add dry run publish to CI * Rename * Refactor workflows. * Remove redundant newlines. * Fix * Fix: add required pat * Should fix ci * Should fix publish * Bump vscode version to 1.64.0 (#30) * Bump vscode version to 1.64.0 * Install vsce as a dev dependency. * Attempt to fix ci * revert * Install prettier as dev dep * Don't use npx * Don't use action for format check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the error here: https://github.com/FuelLabs/sway-vscode-plugin/actions/runs/1907481078
Also removes the use of
npx, which doesn't fix a version and was resulting in unexpected behavior, specifically