Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the memory alignment within the Cortex-R5 port asm code #1023

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

laroche
Copy link
Contributor

@laroche laroche commented Apr 7, 2024

Update alignment in ARM_CR5 port.

This is the same patch as 553caa1 provided by Richard Barry for issue #426 (ARM_CA9).

Description

ARM_CA9 and ARM_CR5 are very close. This patch was applied to ARM_CA9, so it
might also make sense to apply it to ARM_CR5.

Test Steps

This was just observed by looking at the changes between A9 and R5, no real
testing was conducted.

Checklist:

  • I have tested my changes. No regression in existing tests.
  • I have modified and/or added unit-tests to cover the code changes in this Pull Request.

Related Issue

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Update alignment in ARM_CR5 port.

This is the same patch as 553caa1
provided by Richard Barry for issue FreeRTOS#426 (ARM_CA9).

Signed-off-by: Florian La Roche <Florian.LaRoche@gmail.com>
@laroche laroche requested a review from a team as a code owner April 7, 2024 11:01
@xuelix xuelix requested a review from aggarg April 9, 2024 00:47
@xuelix
Copy link
Member

xuelix commented Apr 9, 2024

Thanks for the PR, I am sending to the team for code review.

@aggarg
Copy link
Member

aggarg commented Apr 9, 2024

so it might also make sense to apply it to ARM_CR5.

Did you face any problem or are you making these changes in anticipation of a problem?

@laroche
Copy link
Contributor Author

laroche commented Apr 9, 2024

This patch improves memory alignment for storing the floating point registers when switching
between different tasks. This could be timing critical.

best regards,

Florian La Roche

@aggarg
Copy link
Member

aggarg commented Apr 9, 2024

Thank you for explanation.

Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@aggarg aggarg merged commit 6270e2a into FreeRTOS:main Apr 9, 2024
16 checks passed
@laroche laroche deleted the lr1 branch May 23, 2024 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants