Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-21] [HOLD for payment 2025-01-18] [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched #54988

Closed
1 of 8 tasks
IuliiaHerets opened this issue Jan 9, 2025 · 62 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 9, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other

Action Performed:

  1. Launch hybrid app.
  2. Log in to a new Expensifail account.
  3. After logging in, kill the app.
  4. Relaunch the app.
  5. Kill app and relaunch app several times because sometimes app launches without issue.

Expected Result:

App will not overlap with status bar after killing app and relaunching app.

Actual Result:

App overlaps with status bar after killing app and relaunching app.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6709705_1736408700265.Bug6709620_1736396616448_Screen_Recording_20250109_122013_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021877375704795838083
  • Upwork Job ID: 1877375704795838083
  • Last Price Increase: 2025-01-09
Issue OwnerCurrent Issue Owner: @isabelastisser
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @pecanoro (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

It's happening on my pixel phone as well and it's pretty bad as it's preventing me fro using the app

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

@pecanoro does it happen reliably? You can still click the buttons right?

Definitely not a good UX if its shifted

Gonna ask swm to look into this

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

@mountiny I can't open the menus on the top, I am stuck, so pretty unusable

Screenshot_20250109-120515.png

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

I think it might be due to #51475 but I am not fully sure since I am having trouble testing it

@WoLewicki
Copy link
Contributor

I saw this issue some time ago while working on 0.76 so it is most probably connected. At some point I stopped seeing this so I thought that it is fixed but seems like it is just much less frequent now. But yeah, most probably #48911 is the cause.

@shubham1206agra
Copy link
Contributor

Isn't this issue old? cc @jayeshmangwani

@jayeshmangwani
Copy link
Contributor

@shubham1206agra Yes We have a similar issue when opening the app from a notification here #48190, and I can reliably reproduce that issue.

However, the current issue that occurs when opening the app normally is not reproducible on my end.

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

The problem is that forcing stopping the app doesn't fix it either. Logging out doesn't work either. So I am going to try uninstalling and installing again

@pecanoro
Copy link
Contributor

pecanoro commented Jan 9, 2025

Ok, that didn't work either, now it seems I am stuck in this state forever

@mountiny
Copy link
Contributor

mountiny commented Jan 9, 2025

Seems like the update just made it more prominent but the problem occured before. Maybe its similar root cause as with the other blocker and its a race condition. But since the upgrade of rn made things faster this could show up more often.

As this is last blocker without proposed solution and revert of rn is not desirable i am going to make this external for $500. Hopefully we can fix the issue @jayeshmangwani also mentioned

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 9, 2025
@melvin-bot melvin-bot bot changed the title Hybrid Android - App overlaps with status bar when app is killed and relaunched [$250] Hybrid Android - App overlaps with status bar when app is killed and relaunched Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021877375704795838083

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 9, 2025
@melvin-bot melvin-bot bot added the Weekly KSv2 label Jan 13, 2025
@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Jan 14, 2025

@Julesssss
Oh
Crup
We made 2 PRs related to the OD fix 😅

But after your changes we have this issue

Image

Although my fix is ​​not perfect either 😖

And I suppose we still need changes from this PR
Since we fixed ND issues

@Julesssss
Copy link
Contributor

@ZhenjaHorbach I don't think either are the correct fix yet. Thanks for trying mine though! I'm going to close it.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 14, 2025
@mountiny
Copy link
Contributor

Confirmed fix in staging

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 14, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-18] [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched [HOLD for payment 2025-01-21] [HOLD for payment 2025-01-18] [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched Jan 14, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 14, 2025
Copy link

melvin-bot bot commented Jan 14, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 14, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-21. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 14, 2025

@ZhenjaHorbach @isabelastisser @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jan 17, 2025
Copy link

melvin-bot bot commented Jan 20, 2025

@pecanoro, @arosiclair, @isabelastisser, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick!

Copy link

melvin-bot bot commented Jan 21, 2025

Payment Summary

Upwork Job

BugZero Checklist (@isabelastisser)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1877375704795838083/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@pecanoro
Copy link
Contributor

I don't think this needs payment so closing

@melvin-bot melvin-bot bot removed the Overdue label Jan 21, 2025
@ZhenjaHorbach
Copy link
Contributor

I don't think this needs payment so closing

Actually not sure about 500$ 😅
But I think 250$ makes sense for me
Since I reviewed a PR
And found steps to reproduce twice

@pecanoro
Copy link
Contributor

@ZhenjaHorbach Can you link it? I couldn't find it, that's why I closed it, but it was a long issue so I probably missed it.

@pecanoro
Copy link
Contributor

Oh I see it here! It wasn't showing as approved, so I thought you didn't review it, but now I see the checklist.

@pecanoro
Copy link
Contributor

@isabelastisser $250 for @ZhenjaHorbach here!

@pecanoro pecanoro reopened this Jan 21, 2025
@ZhenjaHorbach
Copy link
Contributor

@isabelastisser $250 for @ZhenjaHorbach here!

Thanks !

@isabelastisser
Copy link
Contributor

Offer sent in Upwork to @ZhenjaHorbach. All set!

@ZhenjaHorbach
Copy link
Contributor

Offer sent in Upwork to @ZhenjaHorbach. All set!

@isabelastisser
I accepted the offer
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.