-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-01-21] [HOLD for payment 2025-01-18] [$500] Hybrid Android - App overlaps with status bar when app is killed and relaunched #54988
Comments
Triggered auto assignment to @pecanoro ( |
Triggered auto assignment to @isabelastisser ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
It's happening on my pixel phone as well and it's pretty bad as it's preventing me fro using the app |
@pecanoro does it happen reliably? You can still click the buttons right? Definitely not a good UX if its shifted Gonna ask swm to look into this |
@mountiny I can't open the menus on the top, I am stuck, so pretty unusable |
I think it might be due to #51475 but I am not fully sure since I am having trouble testing it |
I saw this issue some time ago while working on |
Isn't this issue old? cc @jayeshmangwani |
@shubham1206agra Yes We have a similar issue when opening the app from a notification here #48190, and I can reliably reproduce that issue. However, the current issue that occurs when opening the app normally is not reproducible on my end. |
The problem is that forcing stopping the app doesn't fix it either. Logging out doesn't work either. So I am going to try uninstalling and installing again |
Ok, that didn't work either, now it seems I am stuck in this state forever |
Seems like the update just made it more prominent but the problem occured before. Maybe its similar root cause as with the other blocker and its a race condition. But since the upgrade of rn made things faster this could show up more often. As this is last blocker without proposed solution and revert of rn is not desirable i am going to make this external for $500. Hopefully we can fix the issue @jayeshmangwani also mentioned |
Job added to Upwork: https://www.upwork.com/jobs/~021877375704795838083 |
@Julesssss But after your changes we have this issue ![]() Although my fix is not perfect either 😖 And I suppose we still need changes from this PR |
@ZhenjaHorbach I don't think either are the correct fix yet. Thanks for trying mine though! I'm going to close it. |
Confirmed fix in staging |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.84-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-21. 🎊 For reference, here are some details about the assignees on this issue:
|
@ZhenjaHorbach @isabelastisser @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
@pecanoro, @arosiclair, @isabelastisser, @ZhenjaHorbach Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Payment Summary
BugZero Checklist (@isabelastisser)
|
I don't think this needs payment so closing |
Actually not sure about 500$ 😅 |
@ZhenjaHorbach Can you link it? I couldn't find it, that's why I closed it, but it was a long issue so I probably missed it. |
Oh I see it here! It wasn't showing as approved, so I thought you didn't review it, but now I see the checklist. |
@isabelastisser $250 for @ZhenjaHorbach here! |
Thanks ! |
Offer sent in Upwork to @ZhenjaHorbach. All set! |
@isabelastisser |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.82-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+010108kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Other
Action Performed:
Expected Result:
App will not overlap with status bar after killing app and relaunching app.
Actual Result:
App overlaps with status bar after killing app and relaunching app.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6709705_1736408700265.Bug6709620_1736396616448_Screen_Recording_20250109_122013_Expensify.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @isabelastisserThe text was updated successfully, but these errors were encountered: