Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] Upgrade react-native to 0.76 #48911

Closed
AndrewGable opened this issue Sep 10, 2024 · 25 comments
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item.

Comments

@AndrewGable
Copy link
Contributor

AndrewGable commented Sep 10, 2024

Problem

The new react-native version 0.76 just was released 🎉

https://github.com/facebook/react-native/releases/tag/v0.76.0-rc.0

It contains lots of bug fixes, improvements, and upgrades to the fundamental framework we are using.

Solution

Upgrade to react-native 0.76

cc @staszekscp @j-piasecki @WoLewicki - Per discussion in Slack, can you comment here so I can assign you to work on this? Thanks!

Issue OwnerCurrent Issue Owner: @j-piasecki
@AndrewGable AndrewGable added the Improvement Item broken or needs improvement. label Sep 10, 2024
@AndrewGable AndrewGable self-assigned this Sep 10, 2024
@staszekscp
Copy link
Contributor

Sure! We’ll take care of that!

@j-piasecki
Copy link
Contributor

I'll be helping with the upgrade

@j-piasecki
Copy link
Contributor

I've asked people from Expo and SDK 51 is not compatible with RN 0.76 (it won't compile due to underlying changes). Given that, I believe it may be best to wait for the first beta release of SDK 52 (targeted at the first half of October) before we start the upgrade process. This way we don't have to hack around making SDK 51 compile on the current React Native version, which would have to be discarded anyway. What do you think?

@AndrewGable
Copy link
Contributor Author

This makes sense to me. cc @roryabraham @mountiny @luacmartins

@mountiny
Copy link
Contributor

Same

@luacmartins
Copy link
Contributor

Agreed

@roryabraham
Copy link
Contributor

agreed

@mountiny mountiny self-assigned this Oct 7, 2024
@mountiny
Copy link
Contributor

mountiny commented Oct 7, 2024

Self-assigning as I am happy to help push this ahead in EU timezone

@mountiny
Copy link
Contributor

In progress

Copy link

melvin-bot bot commented Dec 9, 2024

This issue has not been updated in over 15 days. @AndrewGable, @j-piasecki, @mountiny, @staszekscp eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mountiny
Copy link
Contributor

mountiny commented Dec 9, 2024

Still in progress

Copy link

melvin-bot bot commented Jan 9, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2025
@melvin-bot melvin-bot bot changed the title Upgrade react-native to 0.76 [HOLD for payment 2025-01-17] Upgrade react-native to 0.76 Jan 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 11, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-17] Upgrade react-native to 0.76 [HOLD for payment 2025-01-18] [HOLD for payment 2025-01-17] Upgrade react-native to 0.76 Jan 11, 2025
Copy link

melvin-bot bot commented Jan 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.83-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-18. 🎊

For reference, here are some details about the assignees on this issue:

@mountiny
Copy link
Contributor

We made it to production 🙌

@mountiny mountiny added the NewFeature Something to build that is a new item. label Jan 12, 2025
Copy link

melvin-bot bot commented Jan 12, 2025

Triggered auto assignment to @OfstadC (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 12, 2025

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

Copy link

melvin-bot bot commented Jan 12, 2025

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@mountiny
Copy link
Contributor

#I think we should pay @jayeshmangwani $500 for their review and testing, only issues came from hybrid that was tough to test at this point yet. In future update this limitation will be removed too

@OfstadC
Copy link
Contributor

OfstadC commented Jan 16, 2025

So the only payment we need to issue here is to @jayeshmangwani for $500?

Let me know if i'm missing anyone 😃

@mountiny
Copy link
Contributor

Yes I think that will be it! Thank you!

@OfstadC
Copy link
Contributor

OfstadC commented Jan 17, 2025

Payment Summary

@OfstadC OfstadC closed this as completed Jan 17, 2025
@garrettmknight
Copy link
Contributor

garrettmknight commented Jan 21, 2025

$500 approved for @jayeshmangwani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Improvement Item broken or needs improvement. NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

10 participants