Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[CP Staging] fix: remove using StatusBar height" #55180

Closed
wants to merge 2 commits into from

Conversation

Julesssss
Copy link
Contributor

Reverts #55082 in attempt to resolve #54988

@Julesssss Julesssss requested a review from AndrewGable January 13, 2025 23:12
@Julesssss Julesssss self-assigned this Jan 13, 2025
@Julesssss Julesssss requested review from a team as code owners January 13, 2025 23:12
@melvin-bot melvin-bot bot removed the request for review from a team January 13, 2025 23:12
Copy link

melvin-bot bot commented Jan 13, 2025

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link
Contributor

🚧 @Julesssss has triggered a test build. You can view the workflow run here.

Copy link
Contributor

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

@Julesssss Julesssss removed the request for review from a team January 14, 2025 01:24
* main: (31 commits)
  Update Mobile-Expensify to 9.0.85-0
  Update version to 9.0.85-0
  Update Mobile-Expensify to 9.0.84-7
  Update version to 9.0.84-7
  remove the appName
  fix lint error.
  prevent api is called in deactive tab
  Update Mobile-Expensify to 9.0.84-6
  Update version to 9.0.84-6
  Bump Onyx to 2.0.87
  fix ts
  update onyx
  cleanup: remove redundant getSecureEntryKeyboardType function
  refactor: remove getSecureTextEntry method
  fix: remove dynamic keyboardType logic causing keyboard flickering
  review adjustments
  Proposal-Police: GPT-4o Update w/ Structured Response
  update comment
  move review condition
  update implementation
  ...
@Expensify Expensify deleted a comment from github-actions bot Jan 14, 2025
Copy link
Contributor

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/55180/index.html ❌ FAILED ❌
Android The QR code can't be generated, because the iOS build failed
Desktop 💻 Web 🕸️
N/A N/A
N/A N/A

👀 View the workflow run that generated this build 👀

@Julesssss Julesssss closed this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant