Dmonsewicz/updating with upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we should use SassC, that's whole point :)
https-ify sass-lang.com urls
Fix the ordering so that more specialised files are correctly picked
This part of the code was still referencing an older Sass Ruby constant path Fixes sass#128
Correct reference to SassC::Script::Value::String
Rails 6 is currently at an RC1. This should allow any beta or release candidate version without needing to update it. The jruby build fails as it can't find a compatible rails 6 release. Since this installs jruby 9.1, perhaps rails 6 only supports jruby 9.2 (latest)? https://travis-ci.org/sass/sassc-rails/jobs/554811782
With the previous change we were only running CI builds against 3.0.x max.
This was many minor versions behind. We want to ensure our CI uses the current minor version.
Update Travis with Rails 6 and to use all current minor releases
jasich
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.