Fix the ordering so that more specialised files are correctly picked #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
is it possible to add a test case here? |
|
We would like to see this merged before of switching to sassc-rails as the default for Rails 6, there is any chance to get this finished soon? |
|
Sorry for taking so long to give this another go 🙏 @bolandrm I have added a test that ensures my fix works. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing globs(
*s) the current ordering ofEXTENSIONSis not correct.For example if there is a
.scss.erbfile when aglobis expanded, it should be imported byERBExtension.new(".scss.erb")but the current ordering ofEXTENSIONSpicksExtension.new(".scss")which would then fail to parse the.erb.I have re-ordered
EXTENSIONSso that more specialised extensions appear first.