Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Travis with Rails 6 and to use all current minor releases #130

Merged
merged 3 commits into from
Dec 2, 2019

Conversation

javierjulio
Copy link
Contributor

@javierjulio javierjulio commented Jul 5, 2019

This adds a gemfile for running a CI build for Rails 6 (RC1). I thought it would help to get a head start on running CI builds for it to ensure compatibility.

This also addresses issues with the sprockets and sprockets-rails gemfiles where they were many minor versions behind the current version. As an example sprockets was only testing against 3.0.x but the latest minor version is 3.7.x.

I've noticed the jruby builds are only using 9.1.x but the latest is 9.2.x. Would you like an update to run against only 9.2.x?

@javierjulio javierjulio force-pushed the update-ci-gemfiles branch 5 times, most recently from 5c7e261 to 4c81afd Compare July 5, 2019 22:43
Rails 6 is currently at an RC1. This should allow any beta or release candidate version without needing to update it.

The jruby build fails as it can't find a compatible rails 6 release. Since this installs jruby 9.1, perhaps rails 6 only supports jruby 9.2 (latest)? https://travis-ci.org/sass/sassc-rails/jobs/554811782
With the previous change we were only running CI builds against 3.0.x max.
This was many minor versions behind. We want to ensure our CI uses the current minor version.
@javierjulio javierjulio force-pushed the update-ci-gemfiles branch from 4c81afd to 38cc821 Compare July 6, 2019 16:25
@javierjulio
Copy link
Contributor Author

javierjulio commented Jul 6, 2019

The CI build is now passing. No additional changes. There were just some random failures around rvm downloads from what I could tell on the build errors.

@javierjulio javierjulio changed the title Update gemfiles with Rails 6 and to run against current minor releases Update Travis with Rails 6 and to use all current minor releases Jul 8, 2019
@bolandrm bolandrm merged commit 8d0462d into sass:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants