fix(angular): resolve empty dist #9698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
approved these changes
Jun 26, 2024
benelan
added a commit
that referenced
this pull request
Jun 27, 2024
…anup * origin/dev: chore(linting): enable @typescript-eslint/methd-signature-style for safer types (#9690) refactor(block): use icon value as key instead of class for consistency (#9689) chore: fix package-lock versioning (#9702) test(panel): restore coverage for space between footer start/end slots (#9682) test(input-time-zone): tidy up Intl API polyfill/override (#9676) fix(angular): resolve empty dist (#9698) chore: release main (#9697)
benelan
added a commit
that referenced
this pull request
Jun 27, 2024
Merged
benelan
added a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components@2.10.0...@esri/calcite-components@2.10.1) (2024-06-27) ### Miscellaneous Chores * **@esri/calcite-components:** Synchronize components versions </details> <details><summary>@esri/calcite-components-angular: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.0...@esri/calcite-components-angular@2.10.1) (2024-06-27) ### Bug Fixes * **angular:** Resolve empty dist ([#9698](#9698)) ([1bdf5fa](1bdf5fa)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> <details><summary>@esri/calcite-components-react: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.0...@esri/calcite-components-react@2.10.1) (2024-06-27) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
added a commit
that referenced
this pull request
Jun 27, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components@2.10.0...@esri/calcite-components@2.10.1) (2024-06-27) ### Miscellaneous Chores * **@esri/calcite-components:** Synchronize components versions </details> <details><summary>@esri/calcite-components-angular: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.0...@esri/calcite-components-angular@2.10.1) (2024-06-27) ### Bug Fixes * **angular:** Resolve empty dist ([#9698](#9698)) ([1bdf5fa](1bdf5fa)) ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> <details><summary>@esri/calcite-components-react: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.0...@esri/calcite-components-react@2.10.1) (2024-06-27) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize components versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
benelan
added a commit
that referenced
this pull request
Jun 27, 2024
## 🤖 I have created a release _beep_ _boop_ --- <details> <summary>@esri/calcite-components: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components@2.10.0...@esri/calcite-components@2.10.1) (2024-06-27) ### Miscellaneous Chores - **@esri/calcite-components:** Synchronize components versions </details> <details> <summary>@esri/calcite-components-angular: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-angular@2.10.0...@esri/calcite-components-angular@2.10.1) (2024-06-27) ### Bug Fixes - **angular:** Resolve empty dist ([#9698](#9698)) ([1bdf5fa](1bdf5fa)) ### Dependencies - The following workspace dependencies were updated - dependencies \* @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> <details> <summary>@esri/calcite-components-react: 2.10.1</summary> ## [2.10.1](https://github.com/esri/calcite-design-system/compare/@esri/calcite-components-react@2.10.0...@esri/calcite-components-react@2.10.1) (2024-06-27) ### Miscellaneous Chores - **@esri/calcite-components-react:** Synchronize components versions ### Dependencies - The following workspace dependencies were updated - dependencies \* @esri/calcite-components bumped from ^2.10.1-next.0 to ^2.10.1 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Unfortunately, the
2.10.0release didn't fix the empty Angular dist. After some digging, it started in2.9.0-next.24. These are the suspicious commits:In #9428 I added the
filesfield to thepackage.jsonso the dist files could be added to the GitHub releases. It seems like that broke the actual releases, because Angular has really strange workflow where they copy thepackage.jsoninto thedistand release from there.