ci: upload dist to github releases #9428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelan
added a commit
that referenced
this pull request
May 29, 2024
* main: docs: update component READMEs (#9446) build: update browserslist db (#9445) ci(renovate): remove noisy sections from the PR body (#9441) refactor(storybook): replace fake knobs with controls for simple stories (#9385) build: remove unnecessary dist files before publishing (#9439) build(deps): update dependency axe-core to v4.9.1 (#9436) ci: combine related actions into single workflow file (#9434) build(deps): update dependency @floating-ui/dom to v1.6.5 (#9435) build(deps): update angular monorepo to v17.3.10 (#9431) ci: upload dist to github releases (#9428) ci: skip chromatic for release and doc update PRs (#9430) ci: enable npm provenance statements (#9429)
benelan
added a commit
that referenced
this pull request
May 30, 2024
**Related Issue:** #9428 ## Summary The new [script](https://github.com/Esri/calcite-design-system/blob/main/support/uploadReleaseAssets.ts) for uploading release assets failed after `2.9.0` was deployed: ```sh > calcite-design-system@0.0.0 util:upload-release-assets 2024-05-29T06:43:20.4633461Z > tsx support/uploadReleaseAssets.ts [packages/calcite-components,packages/calcite-components-react,packages/calcite-components-angular/projects/component-library] SyntaxError: Unexpected token 'p', "[packages/c"... is not valid JSON at JSON.parse (<anonymous>) at <anonymous> (/home/runner/work/calcite-design-system/calcite-design-system/support/uploadReleaseAssets.ts:10:35) ``` The quotes were removed from the [`paths_released`](https://github.com/googleapis/release-please-action#outputs) value, which should be valid, stringified JSON. After some digging I came across a solution on [stack overflow](https://stackoverflow.com/a/72955840).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upload dist files to the GitHub Releases after publishing to npm. I'm not sure why I thought release-please was already doing this. I tested locally with the following script, which correctly uploaded the dists, e.g. for release
@esri/calcite-components: v2.8.0.It might be time to recreate a VM so I can iterate through all the tags with missing dists and add them with the script.