Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(panel): restore coverage for space between footer start/end slots #9682

Merged
merged 3 commits into from
Jun 26, 2024
Merged

test(panel): restore coverage for space between footer start/end slots #9682

merged 3 commits into from
Jun 26, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jun 25, 2024 •
edited
Loading

Related Issue: #8981

Summary

Updates panel story to capture default space between footer start/end slots, which was lost in #9681.

@jcfranco jcfranco changed the title jcfranco/restore space check for panel footer start end slots test(panel): restore coverage for space between footer start/end slots Jun 25, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 25, 2024
@jcfranco jcfranco requested a review from Elijbet June 25, 2024 17:28
@jcfranco jcfranco marked this pull request as ready for review June 25, 2024 17:28
@jcfranco jcfranco requested a review from a team as a code owner June 25, 2024 17:28
driskull
driskull approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driskull
Copy link
Member

Nice new github profile photo @jcfranco ⭐ ✨

@jcfranco
Copy link
Member Author

@driskull Thanks! 📸

@jcfranco jcfranco merged commit b23db61 into dev Jun 26, 2024
13 checks passed
@jcfranco jcfranco deleted the jcfranco/restore-space-check-for-panel-footer-start-end-slots branch June 26, 2024 21:30
@github-actions github-actions bot added this to the 2024-07-30 - Jul Release milestone Jun 26, 2024
benelan added a commit that referenced this pull request Jun 27, 2024
@benelan
Merge remote-tracking branch 'origin/dev' into benelan/release-ci-cle…
c4f6daa 
…anup

* origin/dev:
  chore(linting): enable @typescript-eslint/methd-signature-style for safer types (#9690)
  refactor(block): use icon value as key instead of class for consistency (#9689)
  chore: fix package-lock versioning (#9702)
  test(panel): restore coverage for space between footer start/end slots (#9682)
  test(input-time-zone): tidy up Intl API polyfill/override (#9676)
  fix(angular): resolve empty dist (#9698)
  chore: release main (#9697)
benelan pushed a commit that referenced this pull request Jun 27, 2024
@jcfranco @benelan
test(panel): restore coverage for space between footer start/end slots (
d8f8ab4 
#9682)

**Related Issue:** #8981

## Summary

Updates panel story to capture default space between footer start/end
slots, which was lost in #9681.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elijbet Elijbet Elijbet approved these changes

@driskull driskull driskull approved these changes

Assignees

@jcfranco jcfranco

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @driskull @Elijbet