Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flow-item): fix inverted footer start/end slots #9681

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix(flow-item): fix inverted footer start/end slots #9681

merged 1 commit into from
Jun 25, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: #8981

Summary

Fixes DOM order of flow-item footer start/end slots.

Note: flow-item and panel stories were updated to make footer slot content easier to review.

@jcfranco jcfranco requested a review from a team as a code owner June 25, 2024 17:00
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Jun 25, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Jun 25, 2024
benelan
benelan approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@jcfranco jcfranco mentioned this pull request Jun 25, 2024
Merged
@jcfranco jcfranco merged commit 69cd6a5 into dev Jun 25, 2024
10 checks passed
@jcfranco jcfranco deleted the jcfranco/8981-fix-flow-item-footer-slot-order branch June 25, 2024 17:15
@github-actions github-actions bot added this to the 2024-06-25 - Jun Release milestone Jun 25, 2024
@benelan benelan added autorelease: tagged Pull requests created by release-please that were merged and deployed and removed autorelease: tagged Pull requests created by release-please that were merged and deployed labels Jun 26, 2024
jcfranco added a commit that referenced this pull request Jun 26, 2024
@jcfranco
test(panel): restore coverage for space between footer start/end slots (
b23db61 
#9682)

**Related Issue:** #8981

## Summary

Updates panel story to capture default space between footer start/end
slots, which was lost in #9681.
benelan pushed a commit that referenced this pull request Jun 27, 2024
@jcfranco @benelan
test(panel): restore coverage for space between footer start/end slots (
d8f8ab4 
#9682)

**Related Issue:** #8981

## Summary

Updates panel story to capture default space between footer start/end
slots, which was lost in #9681.
@benelan benelan mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@jcfranco jcfranco

Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfranco @benelan