Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: issue template context for issue check and package #7190

Merged
merged 11 commits into from
Jun 28, 2023
Merged

chore: issue template context for issue check and package #7190

merged 11 commits into from
Jun 28, 2023

Conversation

geospatialem
Copy link
Member

Related Issue: n/a

Summary

Adds the following to the a11y, bug, and enhancement templates:

  1. Adds a required checkbox verifying the submitter has checked for existing issues
    image

  2. Adds checkbox options to specify the package of the request
    image

cc @benelan for the ci/action on the checkbox options to add the framework-react label to the CCR checkbox when checked.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jun 16, 2023
@github-actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 24, 2023
benelan added 2 commits June 27, 2023 12:38
@benelan
Merge remote-tracking branch 'origin/master' into geospatialem/chore-…
f0c9d87 
…issue-template-checkbox

* origin/master: (32 commits)
  ci: double build cc when publishing to workaround stencil types bug (#7227)
  build: bump package versions back to 1.5.0-next.5 (#7228)
  chore: release latest (#7144)
  ci: hardcode release version due to reverting feat (#7225)
  fix(tree-item): ensure expanded tree-item is displayed when expanded and made visible (#7216)
  ci(release-please): pin action version and allow manually running action (#7222)
  fix(input, input-number): allows numeric characters. (#7213)
  build(t9n): generate json file containing t9n values (#7214)
  chore: release next
  fix(combobox, dropdown, input-date-picker, input-time-picker, popover, tooltip): Prevent repositioning from affecting other floating components (#7178)
  build: update browserslist db (#7192)
  build: ignore node_modules and build outputs when watching for changes during stencil tests (#7209)
  test: set up `disabled` helper to run a test per use case (#7089)
  ci: set design complete label conditionals (#7206)
  chore: release next
  fix(list): update selectedItems property on all item selection changes (#7204)
  chore: fix sorting logic for t9nmanifest entries (#7203)
  fix(radio-button):  focuses first focusable radio-button element in group. (#7152)
  chore: release next
  fix(alert): update alert queue when an alert is removed from the DOM (#7189)
  ...
@benelan
ci: add action that labels issues with specified packages
48d7364
@benelan benelan removed the Stale Issues or pull requests that have not had recent activity. label Jun 27, 2023
@benelan benelan marked this pull request as ready for review June 27, 2023 20:45
@benelan benelan requested a review from a team as a code owner June 27, 2023 20:45
@benelan
Copy link
Member

benelan commented Jun 27, 2023

Made a couple tweaks to make my life easier:

  • The action will add a label named after the NPM package (minus the @esri scope), e.g. calcite-components or calcite-components-react
  • As of now, this won't work if the package isn't part of the @esri NPM scope. We can refactor later if we end up adding a package in a different scope, but I don't think any @arcgis packages will end up in here.

jcfranco
jcfranco approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! ⚡🤖⚡

.github/workflows/add-package-label.yml Outdated
const packageRegex = /(?<=\[X\]\s@esri\/)[\w-]*$/gm;
const packages = body.match(packageRegex);

if (packages?.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could eliminate this check, and its associated nesting, by providing an empty array as a fallback when assigning packages above:

const packages = body.match(packageRegex) || [];

benelan and others added 6 commits June 27, 2023 17:23
@benelan
chore: review cleanup
2fc7b5d
@jcfranco @benelan
test(commonTests): restore disabled focus target testing for non-"non…
3baf1d5 
…e" focus targets (#7235)

**Related Issue:** N/A

## Summary

Restores [assertions for tab/mouse focusing on disabled
components](https://github.com/Esri/calcite-components/blame/6777b06c5dbad5441ed651d676cd9562d79e6986/packages/calcite-components/src/tests/commonTests.ts#L1044-L1064)
removed in the [`disabled` test helper
refactor](#7089).
@jcfranco @benelan
fix(input-date-picker): reset active date picker date after closing (#…
005836d 
…7219)

**Related Issue:** #6495 

## Summary

This ensures the active date is reset properly after a
`calcite-input-date-picker`'s date picker is closed (either by blurring
or selecting a date).

## Notes

* This adds an internal `reset` method that can be made public in the
future if needed.
* There was an existing `reset` method prior to these changes that seems
to clear the active date when the date picker is blurred or when
`Escape` is pressed. We should revisit this behavior since it was [added
when the input and date picker were a single
component](https://github.com/Esri/calcite-components/blob/v1.0.0-beta.22/src/components/calcite-date/calcite-date.tsx#L263-L270)
and it does seem odd to have the date-picker reset in these scenarios.
cc @macandcheese @SkyeSeitz @ashetland
* Utility test methods to interact with internal components were added
and tests were updated to leverage them
* Slightly increases the duration factor in the tests to work around
#6604

---------

Co-authored-by: Ben Elan <no-reply@benelan.dev>
@jcfranco @benelan
chore(linting): allow e2ePage variable naming (#7236)
ec375a3 
**Related Issue:** N/A

## Summary

Prevents `unicorn/avoid-abbreviations` from flagging `e2ePage`.
@github-actions @benelan
chore: release next
e18044d
@benelan
Merge branch 'master' into geospatialem/chore-issue-template-checkbox
ac7ab25
@benelan benelan added the skip visual snapshots Pull requests that do not need visual regression testing. label Jun 28, 2023
@benelan benelan merged commit e65e3c8 into master Jun 28, 2023
@benelan benelan deleted the geospatialem/chore-issue-template-checkbox branch June 28, 2023 05:38
@github-actions github-actions bot added this to the 2023 July Priorities milestone Jun 28, 2023
@jcfranco jcfranco mentioned this pull request Feb 21, 2024
Merged
@jcfranco jcfranco mentioned this pull request Jul 3, 2024
Merged
jcfranco added a commit that referenced this pull request Jul 20, 2024
@jcfranco
test(loader): add component token E2E tests (#9726)
2c5e985 
**Related Issue:** #7190

## Summary

✨🧪✨
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@geospatialem geospatialem

Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2023 July Priorities
Development

Successfully merging this pull request may close these issues.
3 participants
@geospatialem @benelan @jcfranco